kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.35k stars 995 forks source link

Remove setup_win.py and fix supported Pythons #1375

Closed rockstorm101 closed 11 months ago

rockstorm101 commented 11 months ago

Fixes #1357

DivingDuck commented 11 months ago

This looks good. Maybe in addition here a correction as well: https://github.com/kliment/Printrun/blob/2f2b7d721edf56249ac0ed051e133941cc89c79d/setup.py#L83C3-L97C7 (Remove Python 3.6, add Python 3.9, 3.10 for Programming Language)

rockstorm101 commented 11 months ago

(Remove Python 3.6, add Python 3.9, 3.10 for Programming Language)

Sure, done that in https://github.com/kliment/Printrun/blob/07014d1da062d10e8fd2ad02d8fd2da9b26f08fd/setup.py#L92C1-L96C50

DivingDuck commented 11 months ago

So long ago I did a approval - I had to search for the approval button.

rockstorm101 commented 11 months ago

So long ago I did a approval - I had to search for the approval button.

Hahaha, many thanks for your time. I'll merge this then :)