Closed rockstorm101 closed 1 month ago
Only 3 minor suggestions :)
Should we add neofelis2X to the developer list? He did some great work in polishing the UI, support for MacOS, rework for projector tool and testing for this release. (CONTRIBUTORS.md and printrun/pronterface.py, about dialog)
https://github.com/kliment/Printrun/blob/fef39451942a8c6587396dd299d8d090cce0f18b/printrun/pronterface.py#L933
Change of info.SetCopyright('(C) 2011 - 2020')
to info.SetCopyright('(C) 2011 - 2024')
We add support for Windows 32 bit again and probably it will be the last version with 32bit support.
Edit: I did some tests with both X32 and X64 for Pronterface and Pronsole. Guess, what I found...
You need to wait a little bit (again...). There is a problem with SD printing via Pronterface that causes a NoneType TypeError. It do not break printing but as result there is no print status available when print from SD-Card. I have already identify the problem and fixed it locally but it is a little bit too late now for testing the modification. I will send a update tomorrow.
I add an additional PR #1426 that will fix the type error in Pronterface, a minor quirk with print status via SD printing in Pronsole, the mentioned adjustment for copyright year and a fix for issue #1420 on the fly because it was an easy one.
- Should we add neofelis2X to the developer list?
Totally agree. I just added them.
I just force-pushed again cause I forgot to add the line about supporting 32bits on Win. I believe the changelog is complete now. Please let me know if you think there's anything missing.
A quite impressive change log. 👍 I just download the windows versions for a quick test on all versions and the test was running fine. I think we can push the new release :)
It's been a year since the last update but I believe the last blocker for a new release is dealt with now so here we are! If anyone knows of any other blockers, please speak up now. Any additions/improvements to the changelog are welcome as well.
Congratulations to everyone who made this possible!