kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.38k stars 997 forks source link

constant ok messages #1441

Open Tigerwraith opened 3 months ago

Tigerwraith commented 3 months ago

Since I updated from stock Creality firmware from https://github.com/mriscoc/Ender3V2S1 for my Ender. The command window has a constant ok messages populating while the printer is printing. Is there a way to turn these off or filter them out? image

DivingDuck commented 3 months ago

@Tigerwraith sorry for the late response. What version of Pronterface do you run? There is no filter function available. This do ~lot~not look like you have enable debug communications. This is maybe a setup in your firmware or printer setup you can change.

Edit: correct typo

Tigerwraith commented 3 months ago

@DivingDuck I am running 2.1.0. I did only start to see this once I moved to the new firmware.

DivingDuck commented 3 months ago

Thanks for the Info. It is maybe a good idea to ask the people who build this firmware why the behavior change and how you can prevent this continuous logging/debugging information.

Here is something you might like to check: https://marlinfw.org/docs/gcode/M111.html

DivingDuck commented 2 months ago

@Tigerwraith, I guess we can close this issue. There is actual no plan for filtering communication messages in addition to what is implemented with debug communication. I'm not sure if this really makes any sense for Pronterface for a future update as this kind of logging only introduce a hell lot of traffic in communication. In addition it looks for me redundant to the implemented send&receive check via checksum for each line send to the printer.

@rockstorm101 @kliment, any though from your point of view?

Best regards, DD

rockstorm101 commented 1 month ago

@rockstorm101 @kliment, any though from your point of view?

Well, here are my two cents.

All that being said, I guess we would need:

Again, I'm sorry it took me this long to look into this.

Tigerwraith commented 1 month ago

I have since moved on from using Marlin2 to Klipper on my Ender. I was using Orca Slicer (I have now moved to Bambu Slicer due to stringing issues using Orca)

It seemed to me that the ok message was for every single command not just specific ones. This is what the creator of the firmware had said to me, image I never did get around to compiling the firmware with that advance feature turned off so I do not know if it worked.

DivingDuck commented 1 month ago

Marlin doc: ADVANCED_OK:

Advanced OK

//#define ADVANCED_OK

Include extra information about the buffer in “ok” messages. Some hosts will have this feature soon.
This could make the NO_TIMEOUTS unnecessary.

And here is a information for a OctoPrint plugin that uses this output. Mentioning: https://community.octoprint.org/t/a-list-of-recommended-marlin-features/39048 Plugin: https://github.com/chendo/BufferBuddy

rockstorm101 commented 1 month ago

It seemed to me that the ok message was for every single command not just specific ones. This is what the creator of the firmware had said to me,

Aha! Finally some light regarding the mysterious ok N#### P# B# messages. It's a Marlin thing. I'd say we definitely need to handle those better, otherwise we'll get more issues on this regard.

I have since moved on from using Marlin2 to Klipper on my Ender.

I assume you don't see the messages any more then?

Tigerwraith commented 1 month ago

Well no I don't as I don't use pronterface any more. Klipper and Mainsail now.