search

kliment / Printrun

Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software
GNU General Public License v3.0
2.37k stars 997 forks source link

Negative content width #913

Open tobbelobb opened 6 years ago

tobbelobb commented 6 years ago

I had some of the errors as observed in #909's error message:

(pronterface.py:662): Gtk-WARNING **: Negative content width -12 (allocation 22, extents 17x17) while allocating gadget (node button, owner GtkButton)
(pronterface.py:662): Gtk-WARNING **: Negative content width -15 (allocation 19, extents 17x17) while allocating gadget (node button, owner GtkButton)

over and over.

I managed to get rid of them by enlargening the ">" and "+"-buttons.

Commit here

Just enlargening the buttons feels a bit dirty. Shouldn't they automatically resize? I found a discussion somewhere that suggested GTK+3.20 text resize happens at the wrong time: https://trac.wxwidgets.org/ticket/17585

hroncok commented 6 years ago

I've pushed the commit in 5edf6aaa042cfae2ab9b3039d0b87f374e38de20 as a workaround. There are still negative contents widths, for example when I resize the window such that the right console is hidden:

pr1

pr2

(pronterface.py:6439): Gtk-WARNING **: Negative content width -2 (allocation 8, extents 5x5) while allocating gadget (node entry, owner GtkEntry)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -5 (allocation 5, extents 5x5) while allocating gadget (node entry, owner GtkEntry)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -8 (allocation 2, extents 5x5) while allocating gadget (node entry, owner GtkEntry)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -9 (allocation 1, extents 5x5) while allocating gadget (node entry, owner GtkEntry)

pr3

(pronterface.py:6439): Gtk-WARNING **: Negative content width -17 (allocation 1, extents 9x9) while allocating gadget (node button, owner GtkButton)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -17 (allocation 1, extents 9x9) while allocating gadget (node button, owner GtkButton)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -1 (allocation 1, extents 1x1) while allocating gadget (node scrolledwindow, owner GtkScrolledWindow)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -9 (allocation 1, extents 5x5) while allocating gadget (node entry, owner GtkEntry)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -17 (allocation 1, extents 9x9) while allocating gadget (node button, owner GtkButton)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -17 (allocation 1, extents 9x9) while allocating gadget (node button, owner GtkButton)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -1 (allocation 1, extents 1x1) while allocating gadget (node scrolledwindow, owner GtkScrolledWindow)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -17 (allocation 1, extents 9x9) while allocating gadget (node button, owner GtkButton)

(pronterface.py:6439): Gtk-WARNING **: Negative content width -17 (allocation 1, extents 9x9) while allocating gadget (node button, owner GtkButton)
tobbelobb commented 6 years ago

The text field beside the send button looks squashed (gone) in your second screendump. Could that be the GtkEntry?

hroncok commented 6 years ago

Probably.

kliment commented 6 years ago

As this is now the only bug blocking the 2.x release I think it's time to make a new RC

hroncok commented 6 years ago

https://github.com/kliment/Printrun/releases/tag/printrun-2.0.0rc4