search

kliment / Sprinter

Firmware for RepRap printers and similar devices
432 stars 329 forks source link

comment_mode broken #140

Closed jschleic closed 12 years ago

jschleic commented 12 years ago

The comment_mode does not work: Trying to send a comment line starting with ";" does block the communication completely and subsequent commands are ignored. Only a reset can re-activate the controller. And a comment following a command in the same line is not interpreted; the whole line is currently ignored.

kliment commented 12 years ago

Is this in master or experimental?

On Wed, Feb 22, 2012 at 12:39 PM, Joachim Schleicher reply@reply.github.com wrote:

The comment_mode does not work: Trying to send a comment line starting with ";" does block the communication completely and subsequent commands are ignored. Only a reset can re-activate the controller. And a comment following a command in the same line is not interpreted; the whole line is currently ignored.

Reply to this email directly or view it on GitHub: https://github.com/kliment/Sprinter/issues/140

jschleic commented 12 years ago

I've tried it with master.

But since there are no changes in the logic of get_command() in experimental, I think it could be reproduced in experimental easily. I'll have a look on that.

jschleic commented 12 years ago

I experience the same problem concerning comments starting with ";" in experimental (although I had to first fix the Makefile to make the experimental branch compile, see #141)