klimeryk
commented
4 years ago Thank you for creating this PR, @thomas-gruen. I appreciate it - I'll try to have a look through your improvements this weekend and see what can be incorporated into the vanilla version. It might also give me a nudge to go try to refresh some code, so thank you! I'm glad you found it useful for a base for your own version - open-source FTW! 🎉
Hello Igor,
as requested in https://github.com/klimeryk/garmodoro/pull/17#issuecomment-613618338 :-)
Here are my refactorings. I hope you'll find them useful. A word of caution: I have only 'tested' the program directly on my watch, since I couldn't get the simulator to run. So a thorough test is definitely advised.
The refactorings contained in this pull request were a prerequisite for my alterations of the program (see https://github.com/thomas-gruen/garmodoro/issues?q= ). I suspect, you won't incorporate these into your code, since they modify the programs behavior. However, if you like to, feel free to pull or cherry pick from my repo.
Last but not least, I want to thank you for writing the program in the first place and for making it available for free so graciously. It was a lot easier to modify this program than to start from scratch.
Best regards, Tom