search

klimeryk / garmodoro

Pomodoro for Garmin devices using Connect IQ
GNU General Public License v3.0
87 stars 23 forks source link

#20 always update time #21

Closed volkov closed 2 years ago

volkov commented 4 years ago

20

vdnhi commented 3 years ago

@klimeryk Hi Igor, I think this merge should be merged because non-updated time make us hard to keep track the current time when rest done.

klimeryk commented 2 years ago

Thank you for the PR, @volkov! I've tested this and it works great (and I appreciate re-using the existing timer!). I had to make a small adjustment. The idleCallback was not being started in one case: when we restarted the pomodoro from the menu. That was a one line fix, though: https://github.com/klimeryk/garmodoro/blob/cc7a4775249198b7cacfcc757103cc355fc7991c/source/StopMenuDelegate.mc#L22

Had to make idleCallback a global function as a result, though 🤷

Thanks again for the PR - I've amended your commit with the above changes and committed in https://github.com/klimeryk/garmodoro/commit/cc7a4775249198b7cacfcc757103cc355fc7991c (preserving you as the commit author, of course).