search

klimeryk / recalendar.js

ReCalendar - create your personalized calendar PDF for ReMarkable tablets
https://recalendar.me/
GNU Affero General Public License v3.0
284 stars 65 forks source link

Reimport Problem #121

Closed chatzenb closed 2 months ago

chatzenb commented 3 months ago

When I re-import my calendar, the days of week get mixed up. Maybe, because I

After re-import, the days are shifted by one.

Bug? Feature? Any workaround idea?

Explanation: I am a teacher and use it for school things only.

klimeryk commented 2 months ago

Thanks for the report, @chatzenb! I can confirm it's a bug - looks like it only happens when you re-import the calendar with the configuration containing start of week on Sundays and disabled days. The disabled days are not marked correctly for some reason. Let me investigate, hoping it's a small fix 🙇

klimeryk commented 2 months ago

This should be fixed in https://github.com/klimeryk/recalendar.js/commit/6e90cc4aa72567dec1c157f53a396f08d2d37444 🙇‍♂️ Sorry for the regression, looks like I caused it recently in https://github.com/klimeryk/recalendar.js/commit/3e74d934fdff3e733cd6e9be7b18c412b31d8030.

You should now be able to just normally re-import the file and the settings should be working as expected. Closing the issue, but please let me know if you notice anything off!

chatzenb commented 2 months ago

Hello,

seems to be OK. Thank you! A cosmetic thing. If you do a preview, you state to do one month only, but you do till 31. January. I, as I start my calendar in September, get 5 months ;-)

Great tool anyway!

Have a nice day.

Christoph

Am So., 18. Aug. 2024 um 21:30 Uhr schrieb Igor Klimer < @.***>:

This should be fixed in 6e90cc4 https://github.com/klimeryk/recalendar.js/commit/6e90cc4aa72567dec1c157f53a396f08d2d37444 🙇‍♂️ Sorry for the regression, looks like I caused it recently in 3e74d93 https://github.com/klimeryk/recalendar.js/commit/3e74d934fdff3e733cd6e9be7b18c412b31d8030 .

You should now be able to just normally re-import the file and the settings should be working as expected. Closing the issue, but please let me know if you notice anything off!

— Reply to this email directly, view it on GitHub https://github.com/klimeryk/recalendar.js/issues/121#issuecomment-2295365796, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6WD667QC4SVDU6XLZAHYDZSDY7HAVCNFSM6AAAAABLKLC5LWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGM3DKNZZGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Liebe Grüße

Christoph