klimeryk / recalendar.js

ReCalendar - create your personalized calendar PDF for ReMarkable tablets
https://recalendar.me/
GNU Affero General Public License v3.0
262 stars 63 forks source link

Special dates of type "Holiday" are not visible on the minicalendar #78

Open ovidiusoft opened 1 year ago

ovidiusoft commented 1 year ago

I am not sure if this is intentional of not, I am guessing it's not and this is a bug:

If the day is a special day of type "Holiday", the minicalendar does not draw a square around that day. If the day has at least one entry of type "Event", it does. The example entries (1, 3, 13 and 14th of January) don't draw squares around 1 and 3, but they do for 13 and 14. The events are present in the day pages, so they are correctly saved to the PDF, it seems only the minicalendar if affected.

Screenshots:

Screenshot 2023-05-26 at 10 36 49 Screenshot 2023-05-26 at 10 37 44 Screenshot 2023-05-26 at 10 37 31
klimeryk commented 1 year ago

Thanks for reporting! This is kinda expected - see #31. "Holiday" type events are supposed to show up like free/holiday days - so, for example, weekend days. Which are just bold. I've made them as bold as possible (font-weight: 1000) 😆 I get that it might be confusing, though. But if I put a box around it, it might just look any other "special" day. I'm open to suggestions, though!

ovidiusoft commented 1 year ago

Ah, I see, good point. I missed that, it's possible the bold was not "boldy" enough for me, or I was just expecting the holidays so be different than regular weekend days. For example, Easter (which is always on a Sunday) should be somehow different than regular Sundays.

What do you feel about the following?

NOT selected days

When the day is selected (applies to the day page and week overview page), keep the current background fill. It would no longer be visible in the minicalendar that it's a holiday (because we have a darker background now), but it shouldn't matter, since both the week and day pages have the long text of the holiday written in the page itself).

How do you feel about that?