search

klimeryk / recalendar

ReCalendar - highly customizable calendar for ReMarkable tablets
GNU General Public License v3.0
195 stars 23 forks source link

Minimum docker support to avoid dependency installation #20

Closed jorgeuriarte closed 2 years ago

jorgeuriarte commented 2 years ago

Just added a Dockerfile so I can use your incredible tool without installing composer and php in my Mac ;) Not the perfect implementation, though. It "builds" a new image just to run the script, when it would be better to have an "official" image and run the whole process with just docker run, but I had no time, sorry.

Thanks for your work!

klimeryk commented 2 years ago

Thank you for the contribution - I do appreciate it (you even added update of the README ❤️). However, I don't have much experience with Docker myself. So I won't be able to maintain this Dockerfile or debug issues with it. So I'm really sorry, but I have to decline this PR 🙇‍♂️ I'll be sure to refer folks to this PR if they want to try it themselves. But merging it to the main repository would mean I'd have to maintain it and that's not something I can take on.

jorgeuriarte commented 2 years ago

Understood. Not that the Dockerfile will need any support, really (unless you change the compose install // php generate.php install sequence, of course).

But it's your project, no problemo ;)