search

klingtnet / rosc

An OSC library for Rust.
Apache License 2.0
173 stars 25 forks source link

Add OscArray type #6

Closed bitzl closed 5 years ago

bitzl commented 5 years ago

Complete implementation for OSC array types. Arrays in this implementation may contain elements with different types, and all types are supported. This includes other arrays, which can be nested as needed.

Experimental encoding implementation for OSC array types to see how this could look like. I'm sure there's still room for improvement, so it's a draft for now.

klingtnet commented 5 years ago

You may have to rebase from master since I did something stupid and force pushed. Nonetheless, it should be the same state as before. Sorry for the inconvenience. Also, please ask me if there's something I can help you with implementing the feature.

bitzl commented 5 years ago

You may have to rebase from master since I did something stupid and force pushed. Nonetheless, it should be the same state as before. Sorry for the inconvenience. Also, please ask me if there's something I can help you with implementing the feature.

Actually, I don't see any problems. Maybe GitHub somehow automagically rebased my fork? Perhaps you could have a look and tell me if there's something I'm missing.

The array type implementation should be complete now, including encoding, decoding and tests for both. Please let me know if there's anything I can (or should) improve.

klingtnet commented 5 years ago

Thank you for the update!

Actually, I don't see any problems. Maybe GitHub somehow automagically rebased my fork? Perhaps you could have a look and tell me if there's something I'm missing.

I was able to force push the previous state again.

The array type implementation should be complete now, including encoding, decoding and tests for both. Please let me know if there's anything I can (or should) improve.

I greatly appreciate your efforts and will take a look on it somewhen this evening. :+1:

klingtnet commented 5 years ago

Thnaks again! Will merge and release!

ClosetGeek-Git commented 10 months ago

I noticed you allow arrays of arrays (nested arrays). I’m struggling to find if this is a normal feature for OSC implementations. The spec doesn’t seem to explicitly say either way.