bundle time tag is OscType, feels like it should be a (u32, u32)

klingtnet / rosc

An OSC library for Rust.

Apache License 2.0

173 stars 25 forks source link

bundle time tag is OscType, feels like it should be a (u32, u32) #9

Closed x37v closed 4 years ago

x37v commented 4 years ago

according to : http://opensoundcontrol.org/spec-1_0 A bundle always has a time tag, which is always 8 bytes.

rosc's OscBundle.timetag is an OscType which means a user must use a match to extract the data. It seems like it should just be a (u32, u32).

klingtnet commented 4 years ago

Thank you for reporting this! I opened a new pull request where I added a new type for OSC time tags called OscTime. My Rust skills are pretty rusty (pun intended), so I am not sure if this is really idiomatic. If you don't mind you can do a review of https://github.com/klingtnet/rosc/pull/10 .