search

klinker-apps / Android-SlidingEmojiKeyboard

Our Sliding Emoji Keyboard app.
297 stars 64 forks source link

Code Refactoring #3

Closed flide closed 7 years ago

flide commented 7 years ago

Hi,

First of all I would like to thank the original author of this project for such a great effort. I had been searching for an open-source emoji keyboard for my own project for a very long time, and this project gave me a really good opportunity to understand more about android IME's.

I have made significant improvements in the code structure, but in my zeal I have ripped out the "unlocker" code out of the "android-emoji's". Apart from that, based on the current structure you should be easily be able to integrate the second redundant "ios-emoji" project into the same. Also, there is a lot less code now to deal with and all classes now work on single responsibility principle... well apart from the "EmojiKeyboardView" maybe, I am a really bad UI designer and it's hard for me to understand the components and how they work to make the UI look as it does, so that piece of code I tried not to touch at all.

klinker24 commented 7 years ago

Very well done, thank you for the help with this!

If you want to do the ios version too, that would be much appreciated, otherwise I will work on this if I get the chance.