search

klinker24 / Android-TextView-LinkBuilder

Insanely easy way to define clickable links within a TextView.
MIT License
1.59k stars 199 forks source link

There is 2 major issues and 1 Imporvment #6

Closed moali2402 closed 9 years ago

moali2402 commented 9 years ago

1st Issue : setHighlightAlpha Doesn't work with Patterns. The Fix : You missed this.highlightAlpha = link.getHighlightAlpha(); in the Link(Link link) constructor.

2nd Issue: If TextView doesn't have any links that match patterns, it doesn't show any text in the textView. The Fix: Move this.spannable = SpannableString.valueOf(text); from addLinkToSpan to any method before Build. or to be more precise, any where before turnPatternsToLinks(); method is called in build.

Improvements : Support LinkBuilder Class using String as parameter not TextView.

klinker24 commented 9 years ago

2 was fixed this morning and your improvement is being discussed here: https://github.com/klinker24/Android-TextView-LinkBuilder/issues/3

klinker24 commented 9 years ago

The first one is now fixed: https://github.com/klinker24/Android-TextView-LinkBuilder/commit/73110639f9060fd27df3b880d9d47f0dde41c9ee