klinker24 / talon-for-twitter-android

The most powerful and beautiful Twitter client available.
https://klinkerapps.com/talon-overview
1.19k stars 183 forks source link

A possible GoogleApiClient leak in 'NotificationCompose' #143

Open AICT20 opened 4 years ago

AICT20 commented 4 years ago

'NotificationCompose' extends 'Compose' and calls its own 'setUpReplyText' method in onCreate. However, I find that 'finish' method can be called in 'setUpReplyText', which can skip the onStop method according to Android documents. Meanwhile, in 'Compose', GoogleApiClient is required in onCreate while released in onStop, there may be a case that GoogleApiClient is never released when 'finish' is called, isn't it?

Maybe a better solution is to override the 'finish' method and release the GoogleApiClient in it if not.