klinker24 / talon-for-twitter-android

The most powerful and beautiful Twitter client available.
https://klinkerapps.com/talon-overview
1.19k stars 183 forks source link

fix Backup/Restore preferences on Android 11+ #167

Open macearl opened 1 year ago

macearl commented 1 year ago

Just a small fix which removes the deprecated getExternalStorageDirectory in favour of the (scoped) getExternalFilesDir

This fixes the backup/restore preferences functionality on Android 11+.

As I'm not really versed in Android Storage best-practices and think that the new scoped, App specific, Storage is not optimal as the backup file will be deleted when you uninstall the App and the backup File is not easily accessible to other Apps I have marked this as a draft, suggested changes/improvements are more than welcome.

There might also be a few other, probably unrelated cosmetic bugs regarding the restore procedure, e.g. if i create a backup, change the theme from dark to light, restore the backup and then try to change the theme again to the light version the app is displayed with the dark theme but the selected entry is already/still the light theme.