klinker41 / article-android

Android library for displaying web articles in a readable format
Other
153 stars 26 forks source link

Ability to change the font size #16

Closed klinker24 closed 7 years ago

klinker24 commented 7 years ago

Many apps already have font size settings built in, we should give developers the opportunity to follow those preferences.

This will just require a new extra on the ArticleIntent for font size in sp. That size should be set for the content of the TextViews, with slight deviations for the domain name and the article title

@klinker41 should be very straightforward, do you foresee any issues? I was going to add this this weekend.

klinker41 commented 7 years ago

No, this will be easy. You won't even have to convert to sp, if you just pass the int value into TextView#setTextSize then that should work.

You'll just have to change some font sizes appropriately, things like the title should be larger than the paragraphs.

klinker24 commented 7 years ago

Done with: https://github.com/klinker41/article-android/commit/80bff3c502179996772265882c95060eefce80af