UI improvements

[klinker41]

• [x] parallax image views
• [x] diagonal separators between images and article
• [x] transparent toolbar and status bar with header behind it
• [x] hide toolbar when scrolling down
• [x] allow for changing color of primary and accent (remember overscroll on recyclerview)
• [x] dark/light theme
• [x] restrict width on tablets
• [x] tune parallax effect
• [x] add loading bar while contacting server

[klinker41]

Parallax image scrolling done with https://github.com/klinker41/article-android/commit/8209a1b254efd0110959fa8e551c3d2fcbaf9b1b and https://github.com/klinker41/article-android/commit/27eabefa249ea477bc08fb6c310704727bb5d550

[klinker24]

Very nice start :)

[klinker41]

Scroll toolbar with https://github.com/klinker41/article-android/commit/75f6faedbb730768a086accbea8ebe6b9231dfc3

@klinker24 you'll have to tell me if you think the parallax effect is too little or too much, I can adjust it very easily.

[klinker24]

Hard to tell until you finish the rest of the UI behind the app I think. Wait until the fluff is done, then we can get a good parallax effect

[klinker41]

I wasn't able to get the transparent toolbar working with the scrolling (trying to add a background color of the toolbar after we scrolled down a ways), so skipping over that for now.

Also commented out the scrolling toolbar, it doesn't make as much sense to do in my opinion when it isn't transparent with content behind it, plus it adds a bit of scrolling lag to the parallax effect on the images.

What the solution might be is to implement the toolbar hiding and showing myself instead of doing it through the design support library. The lag was coming from resizing the recyclerview as the toolbar hid, which would be eliminated if we could get the toolbar to overlay the recyclerview instead of the recyclerview being placed below it like the coordinator layout forces when scrolling on the toolbar is enabled.

[klinker41]

Created a branch that includes transparent toolbar and status bar. I don't really think it looks very good.

https://github.com/klinker41/article-android/tree/transparency

[klinker41]

Transparent toolbar and status bar + scrolling effect on them is now done.

[klinker41]

Colors can be changed on the article activity now using ArticleActivity.EXTRA_PRIMARY_COLOR and ArticleActivity.EXTRA_ACCENT_COLOR with https://github.com/klinker41/article-android/commit/83a84a98bdd61a3173ececf2f9940515bd66fc6f

[klinker41]

Light/dark mode done with https://github.com/klinker41/article-android/commit/99581237231414885e7473d3ff19ba41178a28da

[klinker41]

Progress bar while loading article: https://github.com/klinker41/article-android/commit/f354368ad705e719fd29d3ff95356df932868a0f

[klinker41]

Diagonal divider between title and header image: https://github.com/klinker41/article-android/commit/98f855fd02128882e9baa4772115c47d050ccd0b

@klinker24 What are your thoughts on this? Look good, need more improvement? Steeper slant or less? Less room between the title and the top of the slant? Font sizes look funny where there are three different ones between the source, title and author?

I decided to add the article's source above the title so that it filled in that diagonal slightly. I also decided not to do this on each of the inline images for an article. It would be too difficult to decide which images to apply it to and the text wrapping just wouldn't be possible for the textview at the bottom of a paragraph before an image.

[klinker41]

I'm considering removing the author from the title view and just having the source above the title instead. The author is very inconsistent to grab, not that important and doesn't look very good when the source is on top in my opinion. Thoughts?

[klinker24]

I think that is awesome! I agree that removing the author would be fine, have noticed that it is pretty weird about the author, sometimes giving twitter handles, etc.

Looks sweet though!

On Sat, Nov 5, 2016, 1:35 AM Jacob Klinker notifications@github.com wrote:

I'm considering removing the author from the title view and just having the source above the title instead. The author is very inconsistent to grab, not that important and doesn't look very good when the source is on top in my opinion. Thoughts?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/klinker41/article-android/issues/2#issuecomment-258594535, or mute the thread https://github.com/notifications/unsubscribe-auth/AEpgL9i1GC4mSQl67M3xFJgYwKt461jsks5q7CPDgaJpZM4Km2Gs .

Luke Klinker Klinker Apps Lead Software Engineer

[klinker41]

Done with tablet support: https://github.com/klinker41/article-android/commits/master

[klinker41]

@klinker24 anything else you can think of for the UI elements that I could add?