klintan / ros2_video_streamer

Python video streamer or camera simulator in ROS2
MIT License
25 stars 17 forks source link

ROS arguments passed via the CLI crash the node #10

Closed kagibson closed 1 week ago

kagibson commented 2 weeks ago

Due to the use of Argparser, the following doesn't work:

root@157a769a5753:/workspace# ros2 run camera_simulator camera_simulator --type video --path /videos/camera0.mov --loop --ros-args -p image_topic:='raw_images'
usage: camera_simulator [-h] --path PATH [--calibration_file CALIBRATION_FILE] [--type TYPE] [--start START] [--loop]
camera_simulator: error: unrecognized arguments: --ros-args -p image_topic:=raw_images
[ros2run]: Process exited with failure 2
kagibson commented 2 weeks ago

I've created a PR with a simple fix for this https://github.com/klintan/ros2_video_streamer/pull/9

klintan commented 1 week ago

Merged!

kagibson commented 1 week ago

thank you!