Store state in its own namespace

kliph / sunrise

Procedurally generates sunrises and sunsets

MIT License

0 stars 0 forks source link

Store state in its own namespace #14

Closed kliph closed 6 years ago

kliph commented 6 years ago

Fixes #13 by removing circular dependency

kliph commented 6 years ago

@ryanhinkel LGTM. I agree that we can hold off on moving the window to its own namespace for now. I think you have to review this since I made the PR.

ryanhinkel commented 6 years ago

I'm happy with the back and forth we had here.

After a little more though, I think the real reason I wanted to keep get-window-dimensions out of sunrise.state is that anything that operates on application state should be a pure function.