search

klis87 / django-cloudinary-storage

Django package that provides Cloudinary storages for both media and static files as well as management commands for removing unnecessary files.
MIT License
131 stars 26 forks source link

Added Django 3 Support #19

Closed tiagocordeiro closed 4 years ago

klis87 commented 4 years ago

@tiagocordeiro Thank you so much for this! And apologies for my late response, it was Christmas time :)

I have several questions: 1) Only Django 1.11 LTS supports Python 2, which won't be supported after April 2020, so maybe we could just get rid of Python 2 altogether? Then six package won't be needed at all then 2) I see some tests commented, they stopped working or there is another reason for this? 3) nice idea with Travis, I am afraid it won't work though as it won't have access to cloudinary credential vars, unless I am missing sth? Perhaps I will need to set them as env variables in Travis admin panel? 4) there are other questions but I will ask them as review comments

tiagocordeiro commented 4 years ago

Hi @klis87 , I apologize for the delay, I was away these days. answering your first comment:

  1. I agree
  2. I had no success with these tests. There is a strange MagicMock behavior with Django 3, you can check it here: https://travis-ci.org/tiagocordeiro/django-cloudinary-storage/jobs/626727446
  3. To use tox in travis simply add credentials as environment variables in project settings in travis
  4. ok Ps.: I'm still crawling with Python / Django and mostly automated testing. My English doesn't help either, but I'll try.
klis87 commented 4 years ago

@tiagocordeiro No worries, we do it in our free time anyway so no rush expected:)

2) Please let me know if you solved it

Ps. Your English is fine, understood everything :)

klis87 commented 4 years ago

@tiagocordeiro thx for updates. From the diff I guess that the only thing left is fixing tests for newest Django right?

tomek-i commented 4 years ago

@tiagocordeiro why did this close? you decided to leave it as is?