Closed ghost closed 2 years ago
Hi @kljohann, just wondering if you took a look at this. If you deem this out of scope from the original intent of mpv.el
, I can package it in an extras package which refers to this one and perhaps mention it the project wiki.
Thanks for the ping, I missed the pull request. I'll take a closer look soon, but I think it's fine to include it with mpv instead of a separate package if we remove to dependency on consult. The --
in consult--read
in any case suggests to me that it's considered an internal function and that we should not rely on that interface?
@kljohann Yeah, you're right, it's just a convenience around the Emacs built-in completion API. I've done as requested and removed the consult
dependency.
Ok, great. I'll take a look at your changes today.
This is a great change. Especially the chapters feature is helpful when playing back YouTube videos. I'll merge the PR and land some follow-up changes. Thanks for working on this!
I'll merge the PR and land some follow-up changes.
Now done, please let me know what you think. :slightly_smiling_face:
Hi @kljohann changes look fine! Thanks for merging this :)
This adds some functionality to list/select chapters and playlist entries, as well as performing operations on them like deleting a file from the playlist or setting an A-B loop on a given chapter. It also adds the ability to enqueue a file. I tried to use the built-in Emacs features as much as possible, but I resorted to consult because it's a saner way to prompt for sorted collections, but I can revert it to
completing-read
if you'd like.This is somewhat based off some of empv's functions, but I don't use that package anymore because I personally dislike that it bundles YouTube search results, and I much prefer
mpv.el
's minimal approach of simply being anmpv
client.