klo2k / nexus3-docker

ARM Docker image of Sonatype Nexus Repository Manager (NXRM) (Raspberry Pis - armv7l, aarch64)
GNU General Public License v3.0
109 stars 39 forks source link

upgrade to temurin #17

Closed dinesh-auti closed 2 years ago

dinesh-auti commented 2 years ago
klo2k commented 2 years ago

Thanks for this!

I'll have a look at this over the weekend (and I need to update Nexus version too....).

In the mean time, so I can understand the background + test this:

  1. This is just to keep compatibility with latest JRE release (looks like adoptopenjdk is moving to Adoptium - thanks for letting me know!)
  2. Is there a reason to pull in a JDK instead of just use JRE? I see Adoptium release a JRE too.
  3. Is there anything / what's broken in Nexus that this fixes? (it's more for me to test + verify)

Again thanks and appreciate this PR :+1:

klo2k commented 2 years ago

I've had a closer look and I think I'm gonna move the base image to eclipse-temurin:8-jre-jammy, to keep things simple.

I'm working on that at https://github.com/klo2k/nexus3-docker/tree/pr_17_wip at the moment - once I've tested it I'll clean-up commits > push to this PR (somehow....).

Appreciate your contribution - and sorry for the delay, it's been crazy at work lately....

klo2k commented 2 years ago

Ok the new version is up as klo2k/nexus3:development on docker hub.

Seems to work ok for me on my development 64-bit pi4 .

Feel free to have a test and let me know if anything is broken for you.

I'm gonna squash commits into this PR > merge and create a release sometime this weekend.

klo2k commented 2 years ago

FYI this is merged via 0eefa2b2 🙂