kloggy / HA-Irrigation-Version2

225 stars 55 forks source link

Schedules don't run if "ignore schedules if it is raining" is enabled #10

Closed Bart39 closed 4 years ago

Bart39 commented 4 years ago

Great Project by the way, had it up and running more or less in a day except for one issue. if "ignore schedules if it is raining" is enabled then schedules don't run even if the raining now sensor state is off

issue is in garden_irrigation_triggered.yaml line 88 where the wrong state is checked

{% elif states('input_boolean.irrigation_ignore_schedule_if_raining') == 'on' and states('input_text.irrigation_external_sensor_raining_now') == 'off' %}

should be

{% elif states('input_boolean.irrigation_ignore_schedule_if_raining') == 'on' and states(states('input_text.irrigation_external_sensor_raining_now')) == 'off' %}

kloggy commented 4 years ago

Thanks, I'm glad you like it.

Yes, I think you are right with the error. Unfortunately I didn't test it thoroughly as I don't have a raining sensor! I'll update it in the file now... Thanks for spotting it.