search

kloggy / HA-Irrigation-Version2

225 stars 55 forks source link

Zone actual duration in seconds doesn't get updated when rainfall or temperature multiplier changes #13

Closed ToastedTortilla closed 4 years ago

ToastedTortilla commented 4 years ago

Thanks for the great work on this irrigation controller, and thanks for the very speedy updates!

The multipliers look good now, but I think the list of entities for the 'zone actual duration in seconds' template sensors should include the rainfall and temperature multipliers. The durations get updated when sensor.date changes (at 00:00:00) and the multipliers end up getting updated at 00:00:01 when the previous days data gets cycled, so it appears that the actual duration ends up using the previous day's multiplier since the other entities in the list only change when using/changing something in the UI.

I think adding 'input_number.irrigation_rainfall_multiplier' and 'input_number.irrigation_temp_multiplier' to the entity_id list for each of the 'irrigation_cycle1_zone1_actual_duration_in_seconds' should fix this but I haven't had a chance to try this.

I just had my zones run with an equivalent multiplier of 0.2, but the GUI was displaying 0.65, I believe due to the above. The actual durations got updated once I opened the GUI to poke around.

kloggy commented 4 years ago

You're welcome. Thank you for finding these bugs!

I'll update the files now.