search

kloggy / HA-Irrigation-Version2

225 stars 55 forks source link

Code Update Suggestion (16 zone branch): section_status_last_run.yaml #27

Closed ekkesa closed 3 years ago

ekkesa commented 3 years ago

Hi,

I believe this might have been overlooked in @athan71 16 zone branch.

For the 'Details of last run' to show dynamically correctly as the number of zones changes the following code needs to be added in '/config/lovelace/templates/garden/status/last_run/section_status_last_run.yaml'. Similiar code is already in the 'History Totals' section.

  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone9_previous_duration_in_seconds
        zone: zone9

  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone10_previous_duration_in_seconds
        zone: zone10

  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone11_previous_duration_in_seconds
        zone: zone11

  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone12_previous_duration_in_seconds
        zone: zone12

  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone13_previous_duration_in_seconds
        zone: zone13

  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone14_previous_duration_in_seconds
        zone: zone14

  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone15_previous_duration_in_seconds
        zone: zone15

  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone16_previous_duration_in_seconds
        zone: zone16
davewatson91 commented 3 years ago

This looks like @athan71 has already implemented this.. Figured best to followup since itappears @kloggy doesn't use GitHub for more than a repository.

davewatson91 commented 3 years ago

@ekkesa I've actually rewritten the work that @athan71 undertook to suit the latest bunch of changes, and done a new PR for @kloggy when he gets a chance to implement. I think this issue could be closed 👍🏼