search

kloggy / HA-Irrigation-Version2

225 stars 55 forks source link

16 zones #28

Closed athan71 closed 3 years ago

davewatson91 commented 3 years ago

@kloggy given that users have the ability to enable only as many zones as required, I can't see any downsides to incorporating this PR into the master - is there any chance we can have this happen?

kloggy commented 3 years ago

@davewatson91 The short answer is that I can't see any downsides either... The long answer is that did plan to do this but was too lazy to get around to it, then everything went a bit pear shaped and I lost nearly all my time for work on HA. Not an excuse but that's the way it was.

I would definitely like to incorporate this but as I have said in the introduction to this package I am not really a GitHub user so if I am honest I am not sure how I would merge these changes. Can it be done without losing any other changes that have been made since?

If someone can explain exactly what I need to do then I will happily do it so long as it won't break anything!

Sorry for my GitHub ignorance :-)

davewatson91 commented 3 years ago

@davewatson91 The short answer is that I can't see any downsides either... The long answer is that did plan to do this but was too lazy to get around to it, then everything went a bit pear shaped and I lost nearly all my time for work on HA. Not an excuse but that's the way it was.

I would definitely like to incorporate this but as I have said in the introduction to this package I am not really a GitHub user so if I am honest I am not sure how I would merge these changes. Can it be done without losing any other changes that have been made since?

If someone can explain exactly what I need to do then I will happily do it so long as it won't break anything!

Sorry for my GitHub ignorance :-)

Don't be sorry at all! Can certainly relate to the time problem.

I've never actually managed a repo, but I do know it's possible. The code probably needs to be rechecked with the changes you've made recently though - I'm more than happy to give a hand, as I am going to have to re-do my own as I blew it away chasing the lovelace-gen problem (and typically didn't have a backup).

I'm sure I can get through re-checking, and then work out how to merge the request if you wanted to share write access?

kloggy commented 3 years ago

Fixed in #40 Sorry it took so long ;-)