search

kloggy / HA-Irrigation-Version2

225 stars 55 forks source link

16 Zones - 2021 #40

Closed davewatson91 closed 3 years ago

davewatson91 commented 3 years ago

Hi @kloggy - I've re-baselined the code to suit the updates you've made since the initial 16 zone version was done.

This is showing no issues, and should be able to be merged automatically with your approval 👍🏼

kloggy commented 3 years ago

Hi Dave, Thanks for doing this.

Am I right in thinking that all I need to do is merge this pull request and all your changes will go into the package? If so I am happy to do this but keep in mind that I haven't tested it and I won't easily be able to as I only have eight zones (and not enough time!).

davewatson91 commented 3 years ago

@kloggy that is correct. 👍🏼 you should be able to merge without any conflicts at all now :)

I have done basic testing on my system - all looks ok, and no bugs showing up for me. I certainly haven't put it through it's paces, however given that it's just additional zones (and not new logic), I don't think there should be a problem.