search

kloggy / HA-Irrigation-Version2

225 stars 55 forks source link

Updated irrigation_weather_outlook #45

Closed genestealer closed 1 year ago

davewatson91 commented 3 years ago

Please feel free to correct me if I'm mistaken, but given the Dark Sky API is closed to any new users, and will be shut down by end of 2021 - would we be better off developing a more source agnostic solution? (Just for discussion, do appreciate any development work :) )

genestealer commented 3 years ago

I did not know it was being shutdown, however the "weather_just_icon" prerequisite is wrong and misleading, a sensor called "irrigation_weather_outlook" is required and the icon of that sensor replaces "weather_just_icon".

The PR is still valid from that perspective, even if the data-sources are closed to new users, and will be shut down by end of 2021.

We can simply replace "sensor.darksky*****" with the new source.

davewatson91 commented 3 years ago

Fair points - completely agree, figured it best to ask the question rather than sit in doubt 👍🏼

kloggy commented 3 years ago

Ok...

This is an area of the package that was entirely experimental and just 'a bit of fun' for me when I wrote it. I don't actually use the weather adjustments (although I might in future) and nor do I even use a schedule except when I go on holiday (which hasn't been for a while now ;-) )

I have to go through my entire config and change all my uses of Dark Sky and I began trying out all the new weather sources I have learned about since the DS announcement but never got to deciding which I would use.

But... because I don't really use it I can't remember accurately, but aren't all weather sensors already agnostic?

image