kloi34 / amoguSV

The Ultimate Quaver plugin for editing SVs
MIT License
17 stars 1 forks source link

Wrap period shift and number of scrolls instead of clamping #12

Closed Emik03 closed 4 months ago

Emik03 commented 4 months ago

Addresses a simple usability issue. Phase shift and number of scrolls should wrap around instead of clamping.

Before: 2024-05-23 19-19-31

After: 2024-05-23 19-20-04

I assume expanding the phase shift to 1 is fine since 0.75 is the same as -0.25. Clamping 0.75 to -0.75 would cause a phase shift in 0.5, which is a worse usability issue than clamping it.