search

klokantech / embedr

Embedr.eu - Image Embedding Service (IES) with support for IIIF, OEmbed, zoomable viewer in an iFrame
http://embedr.eu/
European Union Public License 1.1
15 stars 4 forks source link

Add React viewer. #46

Closed tomkr closed 9 years ago

tomkr commented 9 years ago

Most of this is the static files that are a result of my project. The one thing I wasn't able to test was the integration with the item in in the template. If that's not working as expected (it should pass the id to the Viewer component so that it can render the embed popup properly), let me know and we can work something out.

If there are things that need changing in the assets, please fire up an issue on embedr. Thanks in advance.

mzeinstra commented 9 years ago

This is part of #28 I see that @klokan is probably out of office for the next few days (Congratulations!). @o1da can you accept this request so we can check it for bugs before our public demo on Thursday?

tomkr commented 9 years ago

I realised there are issues with the image paths in the viewer, so they won't work yet, but I'm working on a fix.

tomkr commented 9 years ago

@mzeinstra The discussed fix for the image paths has been pushed and is part of this PR too now.

o1da commented 9 years ago

It is deployed. It looks OK, I have realized only two small problems: