search

klokantech / embedr

Embedr.eu - Image Embedding Service (IES) with support for IIIF, OEmbed, zoomable viewer in an iFrame
http://embedr.eu/
European Union Public License 1.1
15 stars 4 forks source link

Updated the viewer. #83

Closed tomkr closed 8 years ago

tomkr commented 8 years ago

The update includes a patched openseadragon. One issue I had was that the key in the tilesource broke the viewer. Perhaps it should be removed from the python code.

mzeinstra commented 8 years ago

@klokan @o1da from my end you can merge this and #82.

mzeinstra commented 8 years ago

@o1da am I right that the code in this pull request are not yet on the server?

o1da commented 8 years ago

It isn't deployed yet. Viewer is broken from this commit - there is static image address, so I have reverted it yet.

mzeinstra commented 8 years ago

@o1da is this an action for @tomkr or can we fix this ourselves?

o1da commented 8 years ago

I don't know what is a difference between previously used React.render and ReactDOM.render from this pull request, but the new one tried to load IIIF image from URL with original static image. So I have just removed this unuseful URL from tilesources and it works - it is deployed.

Another thing from this pull request isn't clear to me - why the sequenceMode: true setting was removed from the OpenSeadragon configuration? How the items with sequences will be shown?

tomkr commented 8 years ago

These two things likely have to do with the newer version of OSD that I included. It did something weird with the url key, trying to fetch it. I meant to put that in my description, but it was quite unclear there.

The sequenceMode: true tried to display controls for the sequences, which is not currently supported by embedr. There is an open issue there for supporting sequences, so once that is resolved it can be put to true again. I hope that clarifies these things.

o1da commented 8 years ago

Which issue connected with the sequences do you mean? The sequences are implemented from early stage of this project. It was tested already.

tomkr commented 8 years ago

It is not implemented in the embedr viewer. So the issue is on that project.

mzeinstra commented 8 years ago

There are no sequences in the front-end at the moment, we were unsure how to implement it properly with regards to embeds, also of facebook and twitter. We will support it in the future.