Javascript when browsing issues via "type ahead" github feature

klokantech / github-time-tracking

Add time tracking to the GitHub Issue Tracker with Harvest Platform.

52 stars 7 forks source link

Javascript when browsing issues via "type ahead" github feature #7

Closed MassiveHiggsField closed 10 years ago

MassiveHiggsField commented 10 years ago

If you search for a ticket and use the github "type ahead" feature, it will link you to a url like "*/issues/1?source=cc" and the plugin will fail with the js error:

Uncaught TypeError: Cannot read property '1' of null chrome-extension://xxx/data/index.js:11

If you remove the ?source=cc part, everything works fine again.

klokan commented 10 years ago

Patch is welcome ;-)

MassiveHiggsField commented 10 years ago

Absolutely right, i'm struggling, but i will get it done (not the code, but requesting a pull etc). Just one question, the element with the class "pull-number" which works as a fallback, is it for pull request detail pages?

calmyournerves commented 10 years ago

Could not reproduce this, maybe I'm doing something wrong, Is this still an issue @MassiveHiggsField?

MassiveHiggsField commented 10 years ago

No this has all been fixed here, sorry forgot to close.