klokantech / ol3raster

OL3 Raster Reprojection
Other
0 stars 0 forks source link

Specification + community discussion #10

Closed klokan closed 9 years ago

klokan commented 9 years ago

Purpose of this ticket is creation of a design document with technical specification which is going to be reviewed by the ol3 core developers (Hangout with core developers) and the community via post at ol3-dev mailing list - with public announcement and request for call (RFC) document.

This is to prepare the community for the future pull request, validate our suggested design and conduct a critical review of the proposed integration with the OL3 and the planned changes in the code.

This must happen very early in the ALPHA milestone.

klokan commented 9 years ago

This original request for this task was the following: Deliverable no.1: Documentation Deliverable (design document with the following).

Deliverable no.2: Attend Critical Design Review Meeting

klokan commented 9 years ago

Early version of the design document is going to be based on the existing Technical notes: https://docs.google.com/a/klokantech.com/document/d/15PQt3k8SHa9jElxwbOg3Ij1JKNctTokS1uTNz_1eI0I/edit

It will be improved and updated with the information for the GitHub tickets in this repository and made available publicly.

To present the proposal - there will be also slides with schematic illustrations of the functionality and proposed required changes in the OL3 API.

klokan commented 9 years ago

The design document has been provided last week via the email.

It is available on Google Docs at: https://docs.google.com/document/d/1Vs3DTRjpgf53sqbBCfauGaPZa1iFX7Br8yDlEG_W6CI/edit?usp=sharing

The two diagrams showing the core triangulation functionality, useful for presentations, are here: ol3raster-triangulation iterative-triangulation

klokan commented 9 years ago

@ahocevar @bartvde - do you have any feedback for the design document?

Otherwise I could write to ol3-dev mailing-list with details about the planned work and we could also discuss this on Hangout with the other developers on Thursday evening?

Does the Hangout has a fixed time slot and URL @bartvde?

bartvde commented 9 years ago

@klokan the hangout is at http://bit.ly/ol-hangout and it's on Thursdays at 17:30 CET. If you could make it this week that would be great.

bartvde commented 9 years ago

@klokan I just read over the design document. Looks good IMHO.

The define for the error threshold has a very long name (ol.DEFAULT_RASTER_REPROJECTION_ERROR_THRESHOLD), we might want to choose something a bit more compact. Also the text seems to be copied from (ol.ENABLE_RASTER_REPROJECTION), since I assume the threshold will not turn on/off the reprojection?

klokan commented 9 years ago

Thanks @bartvde and @ahocevar for the Hangout. The default variable name follows the conventions used elsewhere in the OL3 code already. We have fixed some typos in the design document - including the one you spotted.

klokan commented 9 years ago

The public OL3 ticket about raster reprojection created - visible at: https://github.com/openlayers/ol3/issues/3785 It is linking the Design document on Google Drive and asking the community for additional comments.

The link to this ticket has been published also on the ol3-dev mailing-list.

We had already a design review meeting on the OL3 Hangout, and the document was updated afterwards. If there are new comments from Boundless or the OL3 community - we will react.

I consider this ticket to be finished now. Closing.