search

klorenz / atom-regex-railroad-diagrams

display regex as railroad diagram, if cursor moves to it
MIT License
250 stars 31 forks source link

Fix for #80 #83

Closed ghost closed 7 years ago

ghost commented 7 years ago

remove 'displayBuffer' from regex-railroad-diagram.coffee. Fix for #80 This will eliminate a Deprecated call.

jorng commented 7 years ago

This is working for me, no more deprecated warnings.

PeterTeng commented 7 years ago

Working for me too👍

pr-yemibedu commented 7 years ago

Does this whole project deserve just being forked to carry forward the needed simple changes that are pending?

mikesprague commented 7 years ago

For anyone interested, I published a fork of this project with the necessary updates for Atom v1.13 and up. Not intending to develop it, just fix bugs like these.

If development becomes active on this project again I'll gladly contribute back the updates and close mine.

jorng commented 7 years ago

Thank you @mikesprague

VNeddy commented 7 years ago

This is working for me too, thank you

klorenz commented 7 years ago

Hi Mike,

thank you very much for this work. I had no time last year to work on my projects and I this will continue for a while. (I am building a house with my family :) )

Would you like to be package maintainer?

I can give you access to the repo.

Best regards,

Kiwi

Am 20.02.2017 um 23:50 schrieb Mike Sprague:

For anyone interested, I published a fork of this project with the necessary updates for Atom v1.13 and up. Not intending to develop it, just fix bugs like these.

If development becomes active on this project again I'll gladly contribute back the updates and close mine.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/klorenz/atom-regex-railroad-diagrams/pull/83#issuecomment-281200162, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmrZEO76OUT7dgHGMAJI9sZtHNAzHrtks5rehi2gaJpZM4LqcP_.

pr-yemibedu commented 7 years ago

Hello,

That would be helpful. Best of luck with the construction of your new home. Thank you. Good day.

On 4/10/2017 3:44 AM, Kay-Uwe (Kiwi) wrote:

Hi Mike,

thank you very much for this work. I had no time last year to work on my projects and I this will continue for a while. (I am building a house with my family :) )

Would you like to be package maintainer?

I can give you access to the repo.

Best regards,

Kiwi

Am 20.02.2017 um 23:50 schrieb Mike Sprague:

For anyone interested, I published a fork of this project with the necessary updates for Atom v1.13 and up. Not intending to develop it, just fix bugs like these.

If development becomes active on this project again I'll gladly contribute back the updates and close mine.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub

https://github.com/klorenz/atom-regex-railroad-diagrams/pull/83#issuecomment-281200162, or mute the thread

https://github.com/notifications/unsubscribe-auth/AAmrZEO76OUT7dgHGMAJI9sZtHNAzHrtks5rehi2gaJpZM4LqcP_.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/klorenz/atom-regex-railroad-diagrams/pull/83#issuecomment-292873722, or mute the thread https://github.com/notifications/unsubscribe-auth/AVRYST6XGs8tlHoAD2PJMceJ-Q0PAStwks5rud3LgaJpZM4LqcP_.

mikesprague commented 7 years ago

@klorenz No thanks necessary! It was a minor fix for a minor annoyance. You did all the real work on this package.

I know how that goes (real life getting in the way, etc.). I'd be happy to be maintainer on the project, thanks for reaching out and asking.

Once you add me I'll submit a pull request with my changes and then merge them here. I'll also deprecate my fork and refer people back here.

Cheers!

Mike

klorenz commented 7 years ago

@mikesprague you are collaborator now :)

mikesprague commented 7 years ago

Thanks @klorenz! When I get home from work this evening I'll deprecate my fork and update this repo with the fix.

mikesprague commented 7 years ago

Closed by pull request #88 :fireworks: :tada: