search

klorenz / atom-regex-railroad-diagrams

display regex as railroad diagram, if cursor moves to it
MIT License
250 stars 31 forks source link

Feature Request: Ability to trigger manually with selection #90

Closed dflock closed 7 years ago

dflock commented 7 years ago

As mentioned in various issues (#74, #70), this only works if your regex is recognised as such by atom and is assigned a regex scope. If you have a regex in a string, then it won't be recognised:

need[java_jdk]='^1\.(7|8)'

So, ideally, you could select the regex text, then manually trigger the diagram.

mikesprague commented 7 years ago

@dflock I won't speak for @klorenz but my understanding is that he's pretty tied up with "real life" right now and without time to work on this package (it hasn't been actively developed in some time).

I was added as a contributor because I had previously forked a copy and published my own to address some changes in the Atom API. Eventually, I was added here and closed my fork.

What I'm getting at is that pull requests are welcome - and will be evaluated and merged when appropriate - but it's probably not realistic to expect movement on this anytime soon otherwise.

Feel free to submit a pull request if you want to take a stab at your requested feature. I've also added the help wanted label in case anyone else is looking to contribute. Cheers!

klorenz commented 7 years ago

@dflock, many thanks for this idea. I have implemented a selection and a little editor for regexes, which then can overwrite the selection or be inserted into text.

mikesprague commented 7 years ago

Nice to see the updates, welcome back @klorenz!

dflock commented 7 years ago

Awesome, thanks!