search

klothoplatform / slack-notifier

Slack notification bot
MIT License
3 stars 0 forks source link

smarter decision around diff URL when pushing new commits to a PR #17

Open ghost opened 2 years ago

ghost commented 2 years ago

There are two ways to view a diff:

The first one works if even you do the amend, but just shows the diff without context (ie without the PR it’s part of). The second shows it within the PR, but breaks if the left-side isn’t part of the PR’s current history — that is, if you squash/amended away a previous PR.

Ideally, the bot would be smart enough to use the PR-compare when it can, and the non-PR when it can't.

context: slack thread

ghost commented 1 year ago

It's unclear if this is even possible using the current, webhook-based github integration (as opposed to actually getting github auth creds for the bot).