search

klothoplatform / slack-notifier

Slack notification bot
MIT License
3 stars 0 forks source link

top-level message should include which repo #32

Open ghost opened 1 year ago

ghost commented 1 year ago

Basically:

--- PR #21: Adds NestJS + Sequelize sample app (+17426/-0) by DavidSeptimus-Klotho
+++ PR KlothoPlatform/sample-apps#21: Adds NestJS + Sequelize sample app (+17426/-0) by DavidSeptimus-Klotho

That does make it feel like a lot of link, though:

PR KlothoPlatform/sample-apps#21: Adds NestJS + Sequelize sample app (+17426/-0) by DavidSeptimus-Klotho

Maybe this?

KlothoPlatform/sample-apps PR#21: Adds NestJS + Sequelize sample app (+17426/-0) by DavidSeptimus-Klotho

gordon-klotho commented 1 year ago

Maybe just the repo name? I don't know many cases where that wouldn't be unique enough to understand. The org name / full qualifier could maybe go in the first comment (which currently is only the description) if needed.

Also, while we're here, isn't the PR a bit redundant since the KlothoBot only posts PRs and uses the :pull-request: emoji?

Here's my proposal:

---
:pull-request: sample-apps#21 Adds NestJS + Sequelize sample app
---
by DavidSeptimus-Klotho (+17426/-0)
KlothoPlatform/sample-apps#21
Description:
> ...
---
ghost commented 1 year ago

I like that!