klothoplatform / slack-notifier

Slack notification bot
MIT License
3 stars 0 forks source link

slack doesn't update the top-level message #41

Closed ghost closed 1 year ago

ghost commented 1 year ago

This seems to be a client issue.

Repro (maybe?)

  1. Put up a PR. The message will say it's ready.
  2. Close the PR (merge, close, mark as draft — doesn't matter)
    1. expected: top-level message gets updated with new state
    2. actual: no change
      1. If anyone then replies in the thread, everyone will see the new, latest state

Seems to be that the client caches the top-level message.

We may be able to fix this just by having the bot first update the top-level message, and then post the "PR was merged" message to the thread. This may satisfy the 2.ii.a condition, and thus work around the issue.