kloudlite / helm-charts

Collection of kloudlite helm charts

https://kloudlite.github.io/helm-charts/

GNU Affero General Public License v3.0

4 stars 3 forks source link

fix(kloudlite-autoscalers): fixes cluster autoscaler deployment flags #84

Closed nxtcoder17 closed 9 months ago

nxtcoder17 commented 9 months ago

scale down unneeded time is now configurable via chart values
CA, now upscales to min node count defined in nodepool

pr-explainer-bot[bot] commented 9 months ago

Pull Request Report

Hey there! Here's a report on the changes made in the pull request. Let's dive in!

Changes

Updated the deployment configuration in charts/kloudlite-autoscalers/templates/cluster-autoscaler/deployment.yml.tpl:
- Added the --scale-down-unneeded-time flag with a value of 1m at line 34.
- Added the --enforce-node-group-min-size flag with a value of true at line 36.
- Updated the image tag to kloudlite-v1.0.5-nightly at line 39.

Suggestions

No suggestions provided.

Bugs

No bugs found.

Improvements

No improvements suggested.

Rating

I would rate the code as follows:

Readability: 8/10
Performance: 9/10
Security: 9/10

Great job overall! If you have any questions or need further assistance, feel free to ask. Happy coding!