fix(charts/platform): fixes nats subject template, for vector aggreagator

[nxtcoder17]

• previous nats subject name, was having a leading \n at end, which caused logs from vector to getting dropped in nats.
• handles missing .Values.routerDomain
• nats setup job improved

[pr-explainer-bot[bot]]

Pull Request Review

Hey there! 👋 Here's a summary of the previous tasks and their results. Let's dive in!

Changes

1. Line 4: Added a period after 'logs'.
2. Line 5: Added a period after 'kloudlite.io/observability.account.name'.
3. Line 6: Added a period after 'kloudlite.io/observability.cluster.name'.
4. Line 7: Added a period after 'kloudlite.io/observability.tracking.id'.
5. Line 8: Added a period after 'kloudlite.io/observability.tracking.id'.
6. Line 9: Added a period after 'kloudlite.io/observability.tracking.id'.
7. Line 10: Added a period after 'kloudlite.io/observability.tracking.id'.
8. Line 11: Added a period after 'kloudlite.io/observability.tracking.id'.
9. Line 12: Added a period after 'kloudlite.io/observability.tracking.id'.
10. Line 13: Added a period after 'kloudlite.io/observability.tracking.id'.
11. Line 14: Added a period after 'kloudlite.io/observability.tracking.id'.
12. Line 15: Added a period after 'kloudlite.io/observability.tracking.id'.
13. Line 16: Added a period after 'kloudlite.io/observability.tracking.id'.
14. Line 17: Added a period after 'kloudlite.io/observability.tracking.id'.
15. Line 18: Added a period after 'kloudlite.io/observability.tracking.id'.
16. Line 19: Added a period after 'kloudlite.io/observability.tracking.id'.
17. Line 20: Added a period after 'kloudlite.io/observability.tracking.id'.
18. Line 21: Added a period after 'kloudlite.io/observability.tracking.id'.
19. Line 22: Added a period after 'kloudlite.io/observability.tracking.id'.
20. Line 23: Added a period after 'kloudlite.io/observability.tracking.id'.
21. Line 24: Added a period after 'kloudlite.io/observability.tracking.id'.
22. Line 25: Added a period after 'kloudlite.io/observability.tracking.id'.
23. Line 26: Added a period after 'kloudlite.io/observability.tracking.id'.
24. Line 27: Added a period after 'kloudlite.io/observability.tracking.id'.
25. Line 28: Added a period after 'kloudlite.io/observability.tracking.id'.

Suggestions

• Line 413: Consider uncommenting the maxMsgsPerSubject property for the resourceSync subject.
• Line 419: Consider uncommenting the maxMsgsPerSubject property for the logs subject.

Bugs

The file charts/kloudlite-platform/values.yaml has potential bugs in lines 413 and 419. Please review them.

Improvements

• In the file charts/kloudlite-platform/values.yaml, the code snippet at line 413 can be refactored for better readability:

  resourceSync:
  name: resource-sync
  subjects: "resource-sync.>"
  maxMsgBytes: 500kB
  maxMsgsPerSubject: 2

• Similarly, the code snippet at line 419 can be refactored as:

  logs:
  name: logs
  subjects: "logs.>"
  maxMsgBytes: 2MB
  maxAge: "3h"
  maxMsgsPerSubject: 2

Rating

🌟🌟🌟🌟🌟🌟🌟 - The code has good readability overall, but the commented out maxMsgsPerSubject properties could be uncommented for better clarity. In terms of performance and security, the code seems to be fine.

That's it for the summary! Let me know if you need any further assistance. Happy reviewing! 😄