Open gkjohn opened 9 years ago
Just a comment on point 1, maybe we should add "title" text to all the short terms like this explaining what they are.
1 ... I'll change this to be some sort of title, after the api changes to the branch are sealed. All indicates - all schools, but it should probably go on top and say something different.
2 ... @harisibrahimkv ?
3 ... I need to figure out the solution for this in chartist, maybe twist the labels by 45 degrees and yes the text needs formatting
4 ... @harisibrahimkv / @batpad can check for you.
5 ... 6 ... 7 ... Maybe that's what is being fixed in the api. @harisibrahimkv can respond on these.
9 ... 10 ... I'll make these changes.
11 ... Some api thing again @harisibrahimkv is looking into.
@iambibhas Trying to keep the titles really short. If a boundary gets selected, this thing actually says:
MLA Constituency Bangalore North
In 2 lines - instead of "all". Anyway, I intend to change this altogether.
There was a nasty bug where it was showing same summary data for schools and preschools. This has been fixed.
Thank you :-)
@batpad @meghaklp: The date thing isn't immediate. It's an improvement. Can be after this release also.
Fixed 4 / 8 (no data showing up for web facilities section)
I've fixed 1,3,9,10 in story-ui-fixes
@meghaklp On the respondents type graph, clicking the bars doesn't show the values. Please fix?
The labels can be tilted 45 degrees to make them more readable and the axes ticks should be darker. If possible show horizontal grid-lines as well to help comparison.
@gkjohn - Yeah - that's chartist tool tips that didn't work at first go. I'll try to see how they implement it again now.
@vinayakh - on the mobile, you mean? I've added a 90 degree rotation to that instead of 45. @gkjohn, @batpad - opinions?
Chartist actually defaults to horizontal labels and the label text spilling over onto next lines.
@meghaklp Can you show me what the 90 degree rotation and 45 degree look like, please? Screenshot? Because on my iPhone it still is horizontal only.
Either works just fine for me. Can we change Akshara Staff to just Staff?
@batpad @vinayakh Any particular preference? Else 45.
Staff is ambiguous - Maybe just Akshara?
Also can.
@gkjohn @meghaklp Just Akshara is better. Also 45 is better than 90 for readability (don't have to tilt head to read).
Fixed tooltips on the Chartist bar charts. JQuery upgraded to 1.11.3 on story-chartist-fixes
@gkjohn - above with a colour palette, I think you meant on slack.
Indeed @meghaklp. Fancy rolling it out?
@meghaklp @gkjohn The respondents graphs should be a different colour and the font should be darker. Otherwise it is not readable. See point No. 2/3 at https://medium.com/salesforce-ux/7-things-every-designer-needs-to-know-about-accessibility-64f105f0881b
Rename Surveys -> Community Feedback Stories -> Field Surveys
Change images on top to reflect new headings of sections.
@vinayakh I've changed the chartist label default to be darker. But many of our colours in the prescribed colour palette have contrast issues - @batpad - Perhaps this is a different ticket altogether. We need to check colours both from a print and contrast point of view.
Stories have been renamed to surveys @batpad - should we change the URL alone?
@meghaklp yes. change the URL. But we should also add a 301 Redirect from /stories/ to the new URL, since the /stories/ link has been out there, on twitter, etc. and links should never die :)
You can look at some examples of using RedirectView in urls.py , basically would just also add something like:
url(r'stories/$', RedirectView.as_view(url='/surveys/'))
Let know if anything doesn't make sense. Thanks.
@harisibrahimkv @meghaklp @batpad
On the whole, this is looking insanely good. Thank you.