search

klpdotorg / dubdubdub

Home of KLP. Houses *most* of the data and APIs.
MIT License
5 stars 4 forks source link

Advanced search for KLP schools #563

Open batpad opened 9 years ago

batpad commented 9 years ago

We need a more advanced search to filter KLP schools (and boundaries?) .. just listing out some features that this would need to support here. Everyone, please add to the list. We can discuss features required here and then perhaps break out separate tickets for design and API implementation.

Please add use-cases for the advanced search .. /cc @gkjohn @meghaklp @iambibhas

gkjohn commented 9 years ago
batpad commented 9 years ago

Okei, we should have all those now except "by academic year" .. @iambibhas any idea what might be a good way to filter for schools that have information for a particular academic year?

Will write up some docs for the existing filters, but they're pretty straightforward ..

meghaklp commented 9 years ago

search2

meghaklp commented 9 years ago

Megha Vishwanath [3:23 PM] On this dialogue - the grey sections show up based on the checkboxes checked in the first line of choices. Also, maybe better if transposed for mobile viewing - i.e, headings in the grey section which are now row names, would be better off as column names and the choices agains them can just grow vertically (edited)

Megha Vishwanath [3:24 PM] It's fairly complex... if you had something simpler in mind, let me know. We can talk whenever you have time. (edited)

Sanjay Bhangar [3:46 PM] oo @megha looks really nice ..

Sanjay Bhangar [3:46 PM] not sure if it can really be simplified ..

Gautam John [5:40 PM] This is a little terrifying.

Gautam John [5:41 PM] And wouldn't somethings be better as a multi/select? (edited)

Megha Vishwanath [7:51 PM] Okay, if it's less terrifying, the checkboxes in the grey area can be made into multi selects (not just selects though). But I've rarely seen a multi select in a Mobile form. Have you? @gautam

meghaklp commented 9 years ago

search2 1

meghaklp commented 9 years ago

Tried the "transpose" of row and column that I talked about and multi-select boxes

Megha Vishwanath [8:36 PM] Personally, I still like checkboxes.

Gautam John [8:57 PM] You are correct

gkjohn commented 9 years ago

@meghaklp Can we start simple and work towards complexity? Because this is overwhelming. So, for example, first step to have filter by partner (multi-select) and by partner/program (multi-select). And then by academic year (multi-select)

meghaklp commented 9 years ago

Sure- this is actually a framework for the search, we can start with 2 parameters and then keep adding - each time a check box is selected - a grey area below expands and choices come up.

meghaklp commented 9 years ago

@gkjohn - I still don't like the idea of multi selects. I don't think it makes for good interaction on mobile. But if you insist, we can do multi selects.

gkjohn commented 9 years ago

@meghaklp Sure. Doesn't have to be multi-select as we usually do. Just needs to be a way to select multiple options - any other way is fine.

meghaklp commented 9 years ago

http://www.erichynds.com/examples/jquery-ui-multiselect-widget/demos/ This is pretty nifty

gkjohn commented 9 years ago

@meghaklp Sure. Give it a shot?

meghaklp commented 9 years ago

@batpad @aksanoble - Did either of you start on this? Should I be writing HTML and then leaving the js tie in to api to @aksanoble?

gkjohn commented 9 years ago

@meghaklp @batpad Said most of the APIs done. @iambibhas any idea where?

batpad commented 9 years ago

@gkjohn @iambibhas have added those filters to the SchoolList end-point .. I think I pushed to develop, but may also be in a branch, checking ..

meghaklp commented 9 years ago

search_1 search_2 search_3

meghaklp commented 9 years ago

@gkjohn - So, this is a scrollable search modal, with a multi select. Still fixing some mobile issues.

Not sure if we should just select by program or pick a partner first. What are your thoughts? For now i can comment all other code except the select by programme.

meghaklp commented 9 years ago

On the branch search_modal - @aksanoble @iambibhas - Still fixing some issues though.

gkjohn commented 9 years ago

@meghaklp This looks good. Pick partner first.

meghaklp commented 9 years ago

Think I'm done here @aksanoble @iambibhas . Let's discuss this, when you pick this feature up to work on. The ui changes are on "search-modal".