Tax Exchange Rate - source and target currency codes

klsheng / myinvois-php-sdk

MyInvois SDK for PHP

MIT License

43 stars 18 forks source link

Tax Exchange Rate - source and target currency codes #1

Closed vanjoechua closed 4 months ago

vanjoechua commented 4 months ago

Hi, First of all I want to thank you for this package. It is a god send! I noticed that the Source and Target currency codes for Tax Exchange Rate cant be set. Is it by design or just not implemented?

Sample UBL from LHDN site

<cac:TaxExchangeRate>
<cbc:SourceCurrencyCode>EUR</cbc:SourceCurrencyCode>
<cbc:TargetCurrencyCode>MRY</cbc:TargetCurrencyCode>
<cbc:CalculationRate>5.07</cbc:CalculationRate>
</cac:TaxExchangeRate>

klsheng commented 4 months ago

Missing from implementation. Thanks for informing.

If you found something is missing, you may inform me again.

vanjoechua commented 4 months ago

Thank you!

klsheng commented 4 months ago

Code updated to main branch and tagged as 0.1.5