search

klukule / merlin

Open-source albion online bot in C#
Other
7 stars 6 forks source link

Adding a 'Limit messages' option on console GUI #28

Closed fabriciorissetto closed 7 years ago

fabriciorissetto commented 7 years ago

Adding this button on the console UI to prevent the game to freeze when the bot is running for a while and you unintentionally press backquote. The option is checked as default when you open the console, if unchecked you get all messages

klukule commented 7 years ago

well if you take a look at Console.cs lines 132 and 133 and you will see the limiter I had setup, mere 100k messages is really ok for any decent computer... so I suggest you combine it with that, because it's better not to add any messages (due to memory usage) than just hiding them... and you could probably lower the limit to like 1k or something

fabriciorissetto commented 7 years ago
  1. First: my computer is decent :)
  2. Second: it is not a problem of "memory" usage and yes from CPU/GPU processing when it tries to render all the messages stored

I could test lower current limiter you mentioned to 50k messages, even though it would take hours and hours to populate that number and test it. And I'm pretty sure it will freeze the UI also. I really believe the limit of messages store in the log should be a lot smaller, but this is a different problem (memory concern... maybe would make sense to log the messagens above than 1k in files, etc, but as I said, is another problem that I'm not trying to solve in this PR).

klukule commented 7 years ago

Well, I'm going to merge it, because you have good point... :)

fabriciorissetto commented 7 years ago

Thanks @klukule