Make 'owner' a separate phase

klum-dsl / klum-ast

Turn your models into super models

https://github.com/klum-dsl/klum-ast/wiki

MIT License

3 stars 0 forks source link

Make 'owner' a separate phase #284

Closed pauxus closed 1 year ago

pauxus commented 1 year ago

Currently, owner is run directly after an object has been added.

By moving owner into a separate phase, the code could become cleaner.

However, currently, PostApply Methods might depend on the Owner being already set, thus such methods would need to be moved to one of the later phases.

This could be verified using an AST Visitor

pauxus commented 1 year ago

What about owners of the autocreate phase?

pauxus commented 1 year ago

either:

autocreate calls owners on new objects
owner runs between autocreate and auto-link
owner runs twice

pauxus commented 1 year ago

Combination of 2 and 4 seems like a valid solution

pauxus commented 1 year ago

Makes sense to do this before 2.0, since it fits right into the phases and prevents another big change later.