search

klustair / klustair-helm

Helm chart do deploy klustair with anchore
Apache License 2.0
7 stars 4 forks source link

serviceAccount is not created when missing value. #12

Closed hugodopradofernandes closed 3 years ago

hugodopradofernandes commented 3 years ago

serviceAccount is not created when missing value on helm install command. It's not being created using the template name as documented. When passing a value it works v0.2.6

mms-gianni commented 3 years ago

I can't verify that on my cluster. It worked all as expected. 

kubectl describe serviceaccounts -n klustair               
Name:                default
Namespace:           klustair
Labels:              <none>
Annotations:         <none>
Image pull secrets:  <none>
Mountable secrets:   default-token
Tokens:              default-token
Events:              <none>

Name:                klustair
Namespace:           klustair
Labels:              app.kubernetes.io/instance=klustair
                     app.kubernetes.io/managed-by=Tiller
                     app.kubernetes.io/name=klustair
                     helm.sh/chart=klustair-0.2.6
                     io.cattle.field/appId=klustair
Annotations:         <none>
Image pull secrets:  <none>
Mountable secrets:   klustair-token
Tokens:              klustair-token
Events:              <none>

Do you see any log output or errors?

hugodopradofernandes commented 3 years ago

No error/log, the helm command fails informing the value is empty. I have to pass the parameter with the name

mms-gianni commented 3 years ago

This may be the error. I think the easiest way is to provide values.yaml with a default. 

#$ microk8s helm3 install -f https://raw.githubusercontent.com/klustair/klustair-helm/main/klustair/values.yaml  my-klustair klustair/klustair --version 0.2.7
Error: values don't meet the specifications of the schema(s) in the following chart(s):
klustair:
- serviceAccount.name: Invalid type. Expected: string, given: null

An error occurred when trying to execute 'sudo microk8s.helm3 install -f https://raw.githubusercontent.com/klustair/klustair-helm/main/klustair/values.yaml my-klustair klustair/klustair --version 0.2.7' with 'multipass': returned exit code 1.
#$ microk8s helm3 install --set serviceAccount.name=MyTest my-klustair klustair/klustair --version 0.2.7
NAME: my-klustair
LAST DEPLOYED: Wed Dec 16 15:52:30 2020
NAMESPACE: default
STATUS: deployed
REVISION: 1