search

klutchell / balena-pihole

Pi-hole is a Linux network-level advertisement and Internet tracker blocking application.
https://pi-hole.net
MIT License
301 stars 101 forks source link

Pi-hole v6 will be an alpine-based container #252

Open klutchell opened 1 year ago

klutchell commented 1 year ago

https://github.com/pi-hole/docker-pi-hole/issues/1430#issuecomment-1732666533

We should be prepared to make compatibility changes.

eiddor commented 1 year ago

image

Alpine or Android?

eiddor commented 1 year ago

If it's Alpine, it shouldn't be a big hairy deal - If it's Android, then...

klutchell commented 1 year ago

I was on my phone, it must have auto-corrected.

Yeah, I don't think we will need to change much except some of the packages we install, and the commands we run to set console fonts.

eiddor commented 1 year ago

Ok whew! Is it worth messing with the upstream Dockerfile and testing now or should we just wait until it actually happens?

klutchell commented 1 year ago

I think just wait, we are in no rush and it will be much easier knowing with confidence what we are working with.

DL6ER commented 1 year ago

It may be worth mentioning that the v6 container is now available for some time:

version: "3"
services:
 pihole:
   image: pihole/pihole:development-v6
klutchell commented 1 year ago

Good to know! If I get some time this holiday season I might draft an example PR with the required changes to support v6.

klutchell commented 1 year ago

@DL6ER are we also moving away from s6-overlay by the looks of it? I can go look up the exact changes myself when I dig into it but I high level view of the planned changes would be handy.

DL6ER commented 1 year ago

@promofaux is the docker master, he'd be the best to answer any questions

PromoFaux commented 1 year ago

Master is one word for it. Fake it till you make it I guess!

Yeah, s6-overlay is gone. We took the opportunity to do a complete overhaul - basing on alpine has been a long time goal, so it was a good time to start from scratch!