search

km4ack / patmenu2

Tools for working with Pat Menu
GNU General Public License v3.0
21 stars 9 forks source link

JQ Dependency check/install and GPS change from Ruby to Python #78

Open k-igarashi-ball opened 1 year ago

k-igarashi-ball commented 1 year ago

I noticed that jq was not call out as a dependency and if not installed, it failed silently and acted as if the grid square was not correctly set. Added logic to check for jq and if not to install similar to the ruby logic already existing.

Additionally, ruby 2.3 is EOL with ruby 2.7 going EOL in about two months. Bump the ruby version to ruby 3 which has been running fine on my evolve3.

SpudGunMan commented 1 year ago

Ruby is used so little, I was wondering if a easy Python script is better or using maidenhead.

k-igarashi-ball commented 1 year ago

Knocked up a quick Python script to do that job. It is using python3 which I know can be divisive. Need to do a little bit more testing to see how it handles not having a GPS lock and GPS not being attached and update error handling accordingly but the happy path of the code works.

SpudGunMan commented 1 year ago

Fun this would be one less requirement for the project, as for Python3 it's the future 2 is doa