search

kmackay / micro-ecc

ECDH and ECDSA for 8-bit, 32-bit, and 64-bit processors.
BSD 2-Clause "Simplified" License
1.24k stars 457 forks source link

API change to capture "recovery id" during signing #65

Open doc-hex opened 8 years ago

doc-hex commented 8 years ago

I want to use your wonderful library for message signing in Bitcoin. However, the standard bitcoin signature format includes 2 extra bits: "recid" or "recovery id". This value captures which of the four possible X values that (R, S) imply and allow the specific public key to be recovered from the signature itself. The process is nicely described in this answer on stackexchange.

The problem is uECC_sign_with_k does the right math, and makes valid signatures, but the values I need for recid are not exposed.

I am tempted to change/extend your code to capture these values during the signing process. However, it's a bit beyond my pay grade. What are your thoughts?

kmackay commented 8 years ago

Looks like you should be able to just use:

recid = p[curve->num_bytes] & 0x01

at uECC.c:1200 (in the current revision).

Technically you also need to account for overflow mod n, but that will basically never happen.

doc-hex commented 8 years ago

Thanks! Do you want a pull request which does that? The problem is I have to change the API.

kmackay commented 8 years ago

Try it out and see if it works for you locally first. I'll think about whether/how to do an API change.

doc-hex commented 8 years ago

Hmm. Didn't work. Still gets wrong answer about 50% of the time. I wonder if the "side channel" protection stuff is a factor here.

kmackay commented 8 years ago

OK, I'll look into it in more detail

kmackay commented 8 years ago

My mistake, it should be:

recid = p[num_words] & 0x01;

doc-hex commented 8 years ago

Yes. Works great! I should have noticed that.

mengguang commented 5 years ago

+1 for this feature. It's great to have recovery ID.

Arachnid commented 2 years ago

It would be great to see this small feature integrated into the API!

JiapengLi commented 1 year ago

For those who need recid and pubkey recovery feature. try this trezor's library out, it is btc/eth blockchain friedly. https://github.com/trezor/trezor-firmware/tree/master/crypto